[buddypress-trac] [BuddyPress Trac] #6591: Wrong parameter value for upload_dir filter in BP Attachment API

[buddypress-trac]

#6591: Wrong parameter value for upload_dir filter in BP Attachment API
-------------------------------------+-----------------------
 Reporter:  rittesh.patel            |       Owner:  imath
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  2.4
Component:  Component - Attachments  |     Version:  2.3.0
 Severity:  normal                   |  Resolution:
 Keywords:  dev-feedback has-patch   |
-------------------------------------+-----------------------

Comment (by imath):

 I was about to commit 6591.02.patch, then i had a second thought. I think
 it's safer to reverse the logic. If the plugin needs the original upload
 dir, then it should add an extra parameter when constructing its class
 e.g.:

 {{{
 Extend_Attachment_Class {
         public function __construct() {
                 parent::__construct( array(
                         // the other parameters..
                         'upload_dir_filter_args' => 1,
                 ) );
         }
 }
 }}}

 See 6591.03.patch. What others are thinking about this ?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6591#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac