[buddypress-trac] [BuddyPress Trac] #6675: WP 4.4 deprecates wp_title()

[buddypress-trac]

#6675: WP 4.4 deprecates  wp_title()
------------------------------+------------------
 Reporter:  mercime           |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  2.4
Component:  Component - Core  |     Version:
 Severity:  major             |  Resolution:
 Keywords:  has-patch         |
------------------------------+------------------

Comment (by imath):

 As discussed yesterday in slack, i've just understood why slaFFik and i
 are not just viewing a notice error, but a wrong title on single item
 pages.

 That's because we are testing using a theme that adds support for the
 `title-tag`. In this case the `wp_title()` function is not used in theme's
 header and `bp_modify_page_title()` is simply never fired :)

 - If you test using twentytwelve, you'll see the notice error with a good
 title because this theme doesn't add support for the `title-tag`.
 - If you test using twentyfifteen, you'll see no notice error and a
 "wrong" title for BuddyPress single item pages.

 So the issue is more problematic for themes supporting the `title-tag`
 feature. I'm going to keep on exploring

 Also @slaFFik, about
 > Also SuperGroup > Manage > Settings doesn't generate Settings in the
 title with the patch attached.

 I'm afraid this never existed in BuddyPress. See
 https://buddypress.trac.wordpress.org/browser/tags/2.1/src/bp-core/bp-
 core-filters.php line 463 to 466 - You only have the current single group
 nav and the group's name into the title.

 That's because the Group navigation is a sub nav of the user main
 navigation (It's a subnav of Membership which uses the group's slug as its
 slug), meaning it has no `$bp->bp_nav` entries. As the displayed user has
 `$bp->bp_nav` entries, in your example you're getting 'Message' which is
 an item of `$bp->bp_nav` and  'Compose' which is an item of
 `$bp->bp_option_nav`. So this part: the Group's title tag is not a bug,
 it's more an enhancement we'll be able to work on as soon as #6534 will be
 achieved :)

 So i'm going to test the patch in twentytwelve and twentyfifteen using
 WordPress 3.8 to 4.2.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6675#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac