[buddypress-trac] [BuddyPress Trac] #6672: #item-header should not use `overflow: hidden`
buddypress-trac
noreply at wordpress.org
Tue Oct 20 17:31:18 UTC 2015
#6672: #item-header should not use `overflow: hidden`
--------------------------+---------------------
Reporter: r-a-y | Owner: r-a-y
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 2.4
Component: Appearance | Version: 1.7
Severity: minor | Resolution: fixed
Keywords: has-patch |
--------------------------+---------------------
Comment (by hnla):
>Where are you seeing this?
On the cover images header groups iirc, on the embedded styles for the
cover images, did discuss with Imath briefly who leaves it in our capable
hands :)
We have overflow handling clearing then pseudo element :before adding
content whitespace, it either needs to be overflow to hadle containment or
a full clearfix ruleset.
>Oh, I was thinking we'd use a sass mixin to avoid having to add the bp-
clearfix class to the markup.
Yep good point and probably would if we used scss for the main rules,
however I tend not to like that approach as it starts to pad out the
stylesheet, adding classes to markup tends to be lighter - as long as can
add safely :)
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6672#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list