[buddypress-trac] [BuddyPress Trac] #6569: Let's give post-form.php the love

buddypress-trac noreply at wordpress.org
Sat Oct 17 19:46:01 UTC 2015


#6569: Let's give post-form.php the love
-----------------------------------------+------------------
 Reporter:  modemlooper                  |       Owner:
     Type:  enhancement                  |      Status:  new
 Priority:  normal                       |   Milestone:  2.4
Component:  Appearance - Template Parts  |     Version:  1.2
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch reporter-feedback  |
-----------------------------------------+------------------

Comment (by r-a-y):

 Good point about the template changes, imath!

 I've created a new patch - `js-only.patch` - that does the following:
 - Adds imath's improvements to pass all valid input fields from the
 "What's new" post form to our AJAX post call.  This will allow plugins to
 save their data.
 - Removes all our weird custom `animate()` calls to use `slideUp()` /
 `slideDown()`.  This fixes modemlooper's problem with buttons being
 truncated in comment:23.
 - Tweaks JS to remove the `'active'` CSS class on `focusout` as explained
 in comment:33.
 - Uses `autoresize.js` as explained in comment:33.

 No changes to our templates.  Template changes should probably be done in
 v2.5.

 A few notes about `autoresize.js`:
 - It does not support IE8.
 - There is some jumpiness in IE10-11; I've added a temporary CSS hack to
 fix this, which adds `padding-bottom: 22px` to the `<textarea>` element.
 I know we hate CSS hacks, so this probably will be omitted.  Or we might
 even omit `autoresize.js` from committing.

 The obligatory GIF (captured in Firefox):
 [[Image(http://imgreview.com/i/gVLvj)]]

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6569#comment:39>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list