[buddypress-trac] [BuddyPress Trac] #6535: Entering an invalid username when composing a message shows generic error

[buddypress-trac]

#6535: Entering an invalid username when composing a message shows generic error
-------------------------------------+------------------
 Reporter:  r-a-y                    |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  2.4
Component:  Component - Messaging    |     Version:  1.0
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------

Comment (by r-a-y):

 Thanks for the feedback, boonebgorges.

 > I think returning WP_Error messages for this kind of thing is generally
 a good thing. It stinks that we have to introduce this lame $error_type
 parameter :(

 Yeah, it does.  I was thinking that this technique is something we could
 adopt in some of our older functions that need this type of error message
 feedback.

 So okay to commit?

 ----

 Good points regarding the following:

 > For example, is there a reason why an if ( empty( $this->recipients ) )
 clause belongs in the database access method?

 .

 > And when something goes wrong in one of these methods that is
 legitimately database-related - like a failed $wpdb->query() - $wpdb
 doesn't give us enough information to build an error object anyway.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6535#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac