[buddypress-trac] [BuddyPress Trac] #6649: Compatibility with `WP_Hook`

[buddypress-trac]

#6649: Compatibility with `WP_Hook`
-------------------------------------------------+-------------------------
 Reporter:  boonebgorges                         |       Owner:
     Type:  defect (bug)                         |  boonebgorges
 Priority:  normal                               |      Status:  closed
Component:  API                                  |   Milestone:  2.4
 Severity:  normal                               |     Version:
 Keywords:  has-patch dev-feedback needs-        |  Resolution:  fixed
  testing                                        |
-------------------------------------------------+-------------------------
Changes (by boonebgorges):

 * owner:   => boonebgorges
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"10279"]:
 {{{
 #!CommitTicketReference repository="" revision="10279"
 Support for `WP_Hook` in `bp_get_template_stack()`.

 The proposed `WP_Hook` #WP17817 breaks backward compatibility for plugins
 that
 attempt to manipulate `$wp_filter` in certain ways. For BuddyPress, it
 means
 that we cannot directly modify the callbacks that are currently registered
 as
 an array at `$wp_filter[ $tag ]`, in `bp_get_template_stack()`. Instead,
 when
 `WP_Hook` is not available, we assign the callbacks to a variable
 (leveraging
 `WP_Hook`'s `ArrayAccess`) and manipulate the variable.

 Props jbrinley.
 Fixes #6649.
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6649#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac