[buddypress-trac] [BuddyPress Trac] #6659: Update " (required)" sting in `bp_get_the_profile_field_required_label()`
buddypress-trac
noreply at wordpress.org
Tue Oct 13 21:49:50 UTC 2015
#6659: Update " (required)" sting in `bp_get_the_profile_field_required_label()`
--------------------------------------+------------------------------
Reporter: netweb | Owner: dcavins
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: Awaiting Review
Component: Locale - i18n | Version:
Severity: normal | Resolution:
Keywords: good-first-bug has-patch |
--------------------------------------+------------------------------
Changes (by SergeyBiryukov):
* keywords: needs-patch good-first-bug => good-first-bug has-patch
Comment:
Replying to [comment:5 dcavins]:
> In either case, moving the space outside the span versus leaving it in
the span should be an equivalent case for RTL handling, shouldn't it?
> `Label<span> (required)</span>` versus `Label <span>(required)</span>`
Correct, removing the space from the translatable string and moving it out
of the span is perfectly fine from RTL point of view. Text direction is
still the same.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6659#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list