[buddypress-trac] [BuddyPress Trac] #6622: Missed $args parameter in bp_core_fetch_avatar_filter()

buddypress-trac noreply at wordpress.org
Sun Oct 11 10:44:59 UTC 2015


#6622: Missed $args parameter in bp_core_fetch_avatar_filter()
---------------------------------------------+--------------------
 Reporter:  WeddyWood                        |       Owner:
     Type:  defect (bug)                     |      Status:  new
 Priority:  high                             |   Milestone:  2.4
Component:  API - Avatars                    |     Version:  2.3.3
 Severity:  normal                           |  Resolution:
 Keywords:  good-first-bug has-patch commit  |
---------------------------------------------+--------------------
Changes (by DJPaul):

 * keywords:  good-first-bug has-patch => good-first-bug has-patch commit


Comment:

 I don't think BuddyPress would have made that decision if we were
 implementing that, but as WordPress didn't and it is their filter, we
 shouldn't either.

 I think your patch is fine. The only thing I suggest is to add a `@since
 2.4 Added $args parameter` on the `bp_core_fetch_avatar_filter` function.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6622#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list