[buddypress-trac] [BuddyPress Trac] #5790: If leave a private group and click request membership button before refresh page get -1

[buddypress-trac]

#5790: If leave a private group and click request membership button before refresh
page get -1
--------------------------------+---------------------
 Reporter:  SinOB               |       Owner:  DJPaul
     Type:  defect (bug)        |      Status:  closed
 Priority:  normal              |   Milestone:  2.4
Component:  Component - Groups  |     Version:  2.0
 Severity:  normal              |  Resolution:  fixed
 Keywords:  has-patch           |
--------------------------------+---------------------
Changes (by djpaul):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"10237"]:
 {{{
 #!CommitTicketReference repository="" revision="10237"
 bp-legacy: fix nonce and message when requesting private group membership

 The AJAX handler for the “request private group membership” button was
 sending the wrong nonce in its response when you leave a private group.
 The button refreshes its label to read “request membership” but as the
 nonce was wrong, only “-1” was printed to the screen. Nothing actually
 happened.

 By coincidence, this is one of those legacy parts of BuddyPress where
 markup is shared between a template file and inside an AJAX callback
 function in the PHP. While resolving that duplication is beyond the
 scope of this immediate change, the AJAX version of the template has
 been updated to match the template file (the only change is the button
 label).

 Fixes #5790

 Props lakrisgubben
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5790#comment:17>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac