[buddypress-trac] [BuddyPress Trac] #6591: Wrong parameter value for upload_dir filter in BP Attachment API

[buddypress-trac]

#6591: Wrong parameter value for upload_dir filter in BP Attachment API
-------------------------------------+-----------------------
 Reporter:  rittesh.patel            |       Owner:  imath
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  2.4
Component:  Component - Attachments  |     Version:  2.3.0
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch commit         |
-------------------------------------+-----------------------
Changes (by imath):

 * keywords:  dev-feedback has-patch => has-patch commit


Comment:

 I still think second option is safest. If we are using some functions to
 filter the upload dir and to do something else depending on the passed
 parameters, i can imagine other plugins doing the same.

 Plugins wishing to receive the original upload dir filter simply have to
 add the 'upload_dir_filter_args' and set it to 1 inside the array they use
 to construct their Attachment class.

 6591.04.patch is taking in account the new Cover Image Attachment class
 and improve the unit test.

 I've been testing this patch several times (including some tests with
 plugins) and i think we're ready to have this in :)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6591#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac