[buddypress-trac] [BuddyPress Trac] #6739: New span counter structure interferes with internationalization

[buddypress-trac]

#6739: New span counter structure interferes with internationalization
--------------------------+-----------------------------
 Reporter:  efrap         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  API           |    Version:  2.4.0
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 Insertion of span tags for counters in 3.4 interferes with
 internationalization (from .po files). Fails and falls back to english.

 Ex:

 bp-groups-loader.php 2.4 line 564 - Members does not translate
 {{{#!php
 <?php
 'name'            => sprintf( _x( 'Members %s', 'My Group screen nav',
 'buddypress' ), '<span>' . number_format(
 $this->current_group->total_member_count ) . '</span>' ),
 }}}

 bp-groups-loader.php previous version line 513  - Members translates ok

 {{{#!php
 <?php
 'name'            => sprintf( _x( 'Members <span>%s</span>', 'My Group
 screen nav', 'buddypress' ), number_format(
 $this->current_group->total_member_count ) ),
 }}}



 This problem can be found in a few pages, including:
 activity/entry.php line 67
 activity/index.php line 55
 groups/index.php  lines 49-52
 members/index.php  line 52

 Other internationalization problems of this type exist - I may submit
 other tickets if this one is useful here.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6739>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac