[buddypress-trac] [BuddyPress Trac] #6503: Separate functions for creating a new nav link and registering a screen function.

[buddypress-trac]

#6503: Separate functions for creating a new nav link and registering a screen
function.
------------------------------+-----------------------
 Reporter:  dcavins           |       Owner:
     Type:  enhancement       |      Status:  reopened
 Priority:  normal            |   Milestone:  2.4
Component:  Component - Core  |     Version:  1.2
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |
------------------------------+-----------------------
Changes (by dcavins):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I introduced an access-protection logic error in r10003. The symptom of
 this error is that if you’re not logged in and try to visit a user profile
 protected screen ​_without specifying a subnav slug_​, you get dumped to a
 404 rather than a login and redirect screen. For instance:
 http://bpdev.local/members/cassie/messages/ yields a 404, but
 http://bpdev.local/members/cassie/messages/inbox follows the correct
 behavior and drops you to the login screen. The underlying issue is that a
 `show_for_displayed_user` check was preceding (and preventing) the
 addition of the nav item to the `bp_nav` array. (That nav element needs to
 exist even if the user can’t visit it.)

 Fix is included in `6503.fix-bp-nav.patch`, above.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6503#comment:21>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac