[buddypress-trac] [BuddyPress Trac] #6457: buddypress.css stylesheet overloading behavior change in 2.3-RC1

[buddypress-trac]

#6457: buddypress.css stylesheet overloading behavior change in 2.3-RC1
----------------------------------------+------------------
 Reporter:  dcavins                     |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  high                        |   Milestone:  2.3
Component:  Appearance - Template Pack  |     Version:
 Severity:  blocker                     |  Resolution:
 Keywords:  has-patch                   |
----------------------------------------+------------------

Comment (by johnjamesjacoby):

 [https://buddypress.trac.wordpress.org/attachment/ticket/6457/6457.02.patch
 6457.02.patch] proposes the folliowing:

 * Abolish `BP_SOURCE_SUBDIRECTORY` constant, and use `BP_LOAD_SOURCE`
 instead
 * Set `BP_LOAD_SOURCE` when loading from `/src` in `bp-loader.php`
 * Overload `plugin_dir` and `plugin_url` in `BuddyPress::setup_globals()`
 with `src` or `build` based on state of `BP_LOAD_SOURCE`
 * Add two new loops to `BP_Legacy::locate_asset_in_stack()`: one to add
 matching minified locations, another to check
 `bp_get_template_locations()` rather than a hard-coded array

 This should address the following:
 * `BP_SOURCE_SUBDIRECTORY` was poorly named and duplicated the
 functionality of `BP_LOAD_SOURCE`
 * `BP_LOAD_SOURCE` is now set when the environment is as such
 * DIR and URL are modified just-in-time based on `BP_LOAD_SOURCE` state
 * Assets will attempt to locate both minified (new) and raw (old) sources
 * BONUS: Assets will now also attempt to locate assets according to
 filters attached to `bp_get_template_locations()` results

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6457#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac