[buddypress-trac] [BuddyPress Trac] #6291: Companion stylesheet task - twentyfifteen

buddypress-trac noreply at wordpress.org
Fri May 8 19:49:59 UTC 2015


#6291: Companion stylesheet task - twentyfifteen
------------------------------+-----------------------
 Reporter:  hnla              |       Owner:  hnla
     Type:  enhancement       |      Status:  assigned
 Priority:  high              |   Milestone:  2.3
Component:  Appearance        |     Version:
 Severity:  minor             |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+-----------------------

Comment (by hnla):

 @r-a-y Message box layout is excellent, that is just the sort of forward
 thinking we need on elements like this - alternative approaches to
 visually rendering, I'm with you on the previous/existing standard table
 cell layout being cramped - does this work for all screen sizes, an issue
 though is the way the th bulk select checkbox cell stretches across, maybe
 given the room there it could have a bit of `:after {content: "select
 all";}`

 My only reservation would the use of 'calc' unless it's now airtight with
 all browsers implementing fully with no partials/bugs.

 Spacing I'm fine with if you think it needed it, there were and are areas
 that would take a further pass and adjustment.

 I'm ok with removing zebra striping but not sure I would go as far as
 saying it's passé that smacks of designery notions, striping was a means
 of easing things on the eyes when looking at long sets of rows, I wasn't
 enamoured of what I had done though, but don't want to see that dirty
 yellow background that's crept back in ;) :)

 Cool on the font, actually in twentyfourteen I added a simple mixin for
 font-family for this purpose but hadn't ported that across ( working
 between two sheets one forgets to bring over useful things sometimes) so
 will port that mixin and adjust, but good call, we do want elements to
 either 'inherit' parent styles or state them to override BP set ones.

 I'll patch this a bit later and have a close look, thanks, oh and I'll
 badger on slack to get people to comment on message layout.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6291#comment:34>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list