[buddypress-trac] [BuddyPress Trac] #6331: Star Private Messages

[buddypress-trac]

#6331: Star Private Messages
------------------------------------+-----------------------
 Reporter:  r-a-y                   |       Owner:  r-a-y
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  2.3
Component:  Component - Messaging   |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+-----------------------

Comment (by imath):

 @r-a-y, just tested it and it shapes really great :)

 I like the `bp_is_active()` thing, i find it pretty elegant actually. The
 only thing that disturbs me a little, but i must be overthinking it is
 that the feature is not really registered so doing this `bp_is_active(
 'messages', 'foobar' )` would return true :) At the same time, i see no
 risk about it.

 Some suggestions :
 - Maybe we should add some unit tests about `bp_is_active()` just to sleep
 safe :)
 - I would also sleep better, if there were some kind of capability checks
 before starring an item :) Sorry i haven't seen this in my previous
 comments.
 - I really think we should let people use a different icon stylesheet than
 dashicons if their theme is registering one.
 - we should use `bp_enqueue_scripts` instead of `wp_enqueue_scripts`.

 All these suggestions are in 6331.suggestions.patch, you'll need to apply
 6331.02.patch first.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6331#comment:22>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac