[buddypress-trac] [BuddyPress Trac] #6278: Attachment Library

[buddypress-trac]

#6278: Attachment Library
------------------------------------+-----------------------
 Reporter:  imath                   |       Owner:  imath
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  2.3
Component:  API                     |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+-----------------------

Comment (by imath):

 In the `BP_Attachment_Avatar->crop()` function i was finding interesting
 to use `bp_core_avatar_dimension()` instead of
 `bp_core_avatar_full_width()` && `bp_core_avatar_full_height()` that was a
 mistake. If somebody filters `'bp_core_avatar_full_height'` &&
 `'bp_core_avatar_full_width'`, the new dimensions will not be taken in
 account as bp_core_avatar_dimension is not filtered.

 We need to avoid possible confusion with users as in
 [https://buddypress.trac.wordpress.org/browser/tags/2.2.1/src/bp-core/bp-
 core-avatars.php#L809 2.2] we were using these functions.

 If no objections, i will commit 6278.09.patch.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6278#comment:64>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac