[buddypress-trac] [BuddyPress Trac] #6278: Attachment Library

buddypress-trac noreply at wordpress.org
Sun Mar 29 18:25:36 UTC 2015

#6278: Attachment Library
 Reporter:  imath                   |       Owner:  imath
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  2.3
Component:  API                     |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |

Comment (by imath):

 In [changeset:"9660"]:
 #!CommitTicketReference repository="" revision="9660"
 Improve the `BP_Attachment` class

 - abstract the `BP_Attachment` class, so it must be extended,
 - avoid using `get_class_vars( __CLASS__ )` to get the default values in
 the constructor,
 - sanitize the base_dir if set,
 - make sure the action and file_input parameters are sanitized,
 - use a `is_dir()` check instead of a `file_exists()` one when checking if
 the upload_path exists,
 - use `bp_parse_args()` in the `BP_Attachment->crop()` method and include
 a filter,
 - improve code formatting.

 Props DJPaul

 See #6278

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6278#comment:61>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list