[buddypress-trac] [BuddyPress Trac] #6306: custom post type support for activities

[buddypress-trac]

#6306: custom post type support for activities
----------------------------------+-----------------------
 Reporter:  shanebp               |       Owner:
     Type:  defect (bug)          |      Status:  reopened
 Priority:  normal                |   Milestone:
Component:  Component - Activity  |     Version:  2.2.1
 Severity:  normal                |  Resolution:
 Keywords:                        |
----------------------------------+-----------------------

Comment (by imath):

 Replying to [comment:8 shanebp]:
 > My testing shows that comments tracking does ''not'' work in BP 2.2

 I've used your code, and it's working.
 Your problem is not linked to the Post type activity support we've
 introduced in 2.2, but is linked to #5130.

 Since BuddyPress 2.0, when activating the option 'Allow activity stream
 commenting on blog and forum posts'. The comments made on regular post or
 on the activity of this post are synced. Meaning commenting an activity
 generates a comment and vice versa.

 If you deactivate the option 'Allow activity stream commenting on blog and
 forum posts' then :
 > The result is that comments are ''not'' tracked.
 becomes true

 > The use of ''bp_blogs_activity_new_post_action'' does ''not'' affect the
 entry.
 still doesn't have any effects, you'll need to adapt your code using the
 gist

 > Perhaps a different approach is needed now for those of us who need
 comment tracking?
 If you prefer to use the filter 'bp_blogs_activity_new_post_action' for
 you post type action string you can still use it, see this gist:
 https://gist.github.com/imath/36f588e77a7a574600cb#file-bp-custom-php-L27
 I would advise to use the new way of adding activity support to post
 types, but it's up to you.

 But 'bp_blogs_activity_new_post_action' is there to filter the action of a
 published post, which has nothing to do with the original reason of your
 ticket :
 > But comments on custom post type post are not appearing in the activity
 stream.

 Again: we haven't changed anything in this area since 2.0. Custom post
 types still needs the blogs component to be active and still need to
 filter 'bp_blogs_record_comment_post_types'.

 The only trouble i see is:
 a notice error due to some code introduced in 2.3, i think it's relative
 to #6177

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6306#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac