[buddypress-trac] [BuddyPress Trac] #6301: Group extension access settings disrespected by bp_core_new_subnav_item()

[buddypress-trac]

#6301: Group extension access settings disrespected by bp_core_new_subnav_item()
--------------------------------+------------------------------
 Reporter:  dcavins             |       Owner:
     Type:  defect (bug)        |      Status:  new
 Priority:  normal              |   Milestone:  Awaiting Review
Component:  Component - Groups  |     Version:
 Severity:  minor               |  Resolution:
 Keywords:  has-patch           |
--------------------------------+------------------------------

Comment (by boonebgorges):

 The idea of having an argument in `bp_core_new_subnav_item()` that would
 essentially cause a subnav item not to be created seems pretty
 unappealing. The root problem here is that we hook the screen function and
 create the nav item inside of the same function. A better solution, IMO,
 would be to break these two tasks apart.

 What do you think of something like this: have separate functions for
 registering a subnav item and for attaching a screen function, then swap
 out all BP core usage for these new functions. The old
 `bp_core_new_subnav_item()` (and `bp_core_new_nav_item()`) would stay as-
 is for backward compatibility.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6301#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac