[buddypress-trac] [BuddyPress Trac] #4728: Visibility API refactoring/restructuring

[buddypress-trac]

#4728: Visibility API refactoring/restructuring
------------------------------+-----------------------------
 Reporter:  chrisclayton      |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Future Release
Component:  Component - Core  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |
------------------------------+-----------------------------

Comment (by boonebgorges):

 I like this a lot, r-a-y. Thanks!

 A couple technical thoughts:

 - I think we should probably leave (a reference to) the visibility levels
 at `buddypress()->profile->visibility_levels` for backward compatibility.
 - Instead of overloading `buddypress()->visibility_levels` with the `if (
 empty( $bp->core->visibility_levels ) )` check in
 `bp_register_visibility_level()`, how about declaring the
 `$visibility_levels` property as an array in the class definition of
 `BP_Core_Component`?
 - I don't see any reason why we should prevent people from deregistering
 core visibility levels. It will break lots of things, but as you note, the
 filter is there anyway. Let's solve that problem if it actually turns out
 to be one.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4728#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac