[buddypress-trac] [BuddyPress Trac] #6124: Twentyfifteen BP Companion Stylesheet

buddypress-trac noreply at wordpress.org
Thu Mar 12 18:32:52 UTC 2015

#6124: Twentyfifteen BP Companion Stylesheet
 Reporter:  hnla                         |       Owner:  hnla
     Type:  enhancement                  |      Status:  assigned
 Priority:  normal                       |   Milestone:  Future Release
Component:  Appearance - Template Parts  |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:                               |

Comment (by boonebgorges):

 Replying to [comment:30 DJPaul]:
 > Replying to [comment:26 boonebgorges]:
 > > > If we do run with pre-processor files for this exercise we'll run a
 final production compile to compressed output on commit?
 > >
 > > My thinking was that we would only compile on the 'build' task, for
 purposes of release. Anyone who is running a git/svn checkout would have
 to compile themselves for the purposes of testing.
 > I kind of disagree with this. What I like about our trunk is that anyone
 can check it out, and they can start developing with it immediately. None
 of this build tool rubbish: people don't ever *have* to run `npm install`.
 > I know that statement is a bit simplistic and there are edge cases
 (around the type of work and the contributor's experience level), but if
 we add a SASS file in `src` without also providing a complied version,
 this adds two extra steps to the "How can I grab a dev BP build and start
 hacking on it" process (otherwise you'd waste time figuring out why the
 CSS isn't working on your site, etc).
 > Which I think would be a shame to lose. I want to make clear I am not
 against this course of action but wanted to make sure the consequences
 were clearly spelt out.

 I don't feel very strongly about it. In a purist sense, keeping compiled
 assets in /src/ is not good practice (we don't do it for minified JS
 files, or for RTL files, etc). At the same time, I don't want to raise
 barriers for contribution. If others think that needing to compile Sass is
 an unreasonable hurdle, then I'm fine being overruled on this point. I
 will note, though, that if CSS is checked into the repo, then you're going
 to get contributions in CSS, which will mean a bit more work for
 committers/reviewers, since it'll have to be translated back into Sass

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6124#comment:33>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list