[buddypress-trac] [BuddyPress Trac] #6278: Attachment Library

buddypress-trac noreply at wordpress.org
Thu Mar 5 16:19:01 UTC 2015


#6278: Attachment Library
------------------------------------+------------------
 Reporter:  imath                   |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  2.3
Component:  API                     |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------

Comment (by imath):

 @boonebgorges :)

 I agree with you. But i think, we'll first need to build some more unit
 tests before "unglobalizing" $bp->avatar because so far for instance :
 1- we have `$bp->avatar_admin->original` set
 2- a lot of the things that are set in `$bp->avatar` are also used in
 bp_core_fetch_avatar()
 eg: `bp_core_avatar_upload_path()`, `bp_core_avatar_url()`

 I was also wondering, since we are somehow advising to extend the
 BP_Attachment class if we should abstract it, and use an abstract method
 to be sure to get the upload action ?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6278#comment:16>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list