[buddypress-trac] [BuddyPress Trac] #6107: Missing site titles for BP pages in Twenty Fifteen and new themes which add support to the new title-tag feature
buddypress-trac
noreply at wordpress.org
Thu Mar 5 16:07:51 UTC 2015
#6107: Missing site titles for BP pages in Twenty Fifteen and new themes which add
support to the new title-tag feature
------------------------------+-----------------------
Reporter: mercime | Owner: hnla
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 2.2.2
Component: Component - Core | Version:
Severity: major | Resolution:
Keywords: has-patch |
------------------------------+-----------------------
Comment (by boonebgorges):
I don't totally understand the issue here (IMO if Yoast is doing something
extremely rude that overwrites our own filters, then it should be Yoast's
responsibility not to wipe out our content - either that, or they should
stop filtering on BP pages). That being said, just from a readability
point of view: using argument overloading in `bp_modify_page_title()`, and
using the same function for both filters, makes the logic a bit hard to
follow. Could we convert to having two separate callbacks - one for
'wp_title' and one for 'wp_title_parts' - and each would be a wrapper for
the central logic of `bp_modify_page_title()`?
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6107#comment:20>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list