[buddypress-trac] [BuddyPress Trac] #6278: Attachment Library

buddypress-trac noreply at wordpress.org
Thu Mar 5 15:16:26 UTC 2015

#6278: Attachment Library
 Reporter:  imath                   |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  2.3
Component:  API                     |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |

Comment (by boonebgorges):

 Changes are looking good here - thanks for the rapid progress!

 I understand the need to set the values of `buddypress()->avatar` for
 backward compatibility, and I appreciate the value of using the singleton
 as a poor-man's cache (for stuff like upload paths).

 However, I feel uncomfortable that these requirements are driving the
 architecture here. `buddypress()->avatar->upload()` seems very
 counterintuitive to me. More than that, we end up with global variable
 pollution, so that things like `buddypress()->avatar->original` are still
 set after the upload is complete. IMO avatar instances should be
 independent of each other, and global config data should be set
 separately. Let's not sacrifice what could be a fairly clean OOP design
 for the sake of backward compatibility. Am I off base?

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6278#comment:13>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list