[buddypress-trac] [BuddyPress Trac] #6278: Attachment Library
buddypress-trac
noreply at wordpress.org
Thu Mar 5 06:46:23 UTC 2015
#6278: Attachment Library
------------------------------------+------------------
Reporter: imath | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 2.3
Component: API | Version:
Severity: normal | Resolution:
Keywords: has-patch dev-feedback |
------------------------------------+------------------
Comment (by imath):
@johnjamesjacoby: about `remove_all_filters( 'upload_dir' )`
So far we are not taking in account the fact that a plugin/administrator
... may filter `'upload_dir'` in a more "global" scope than we do.
I can see reasons why we would want to make sure to get an "unfiltered"
`wp_upload_dir()` : for instance we can fear a plugin/theme to play 'not
nicely' in this area.
On the other hand, i'm unsure how an administrator would set a different
path for uploads for "security reasons" (eg: move the uploads out of the
site's web directory) : filtering `'upload_dir'` or defining the
[http://codex.wordpress.org/Editing_wp-config.php#Moving_uploads_folder
UPLOADS] constant.
So i think we have 2 choices :
- do nothing. So far everything seems to be ok with avatars.
- or use a `bp_upload_dir()` out of an unfiltered `wp_upload_dir()`, but
then we would need to explain how to set a different path
What do you think ?
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6278#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list