[buddypress-trac] [BuddyPress Trac] #6270: "bp_message_add_meta()" should be "bp_messages_add_meta()"

buddypress-trac noreply at wordpress.org
Mon Mar 2 17:51:44 UTC 2015


#6270: "bp_message_add_meta()" should be "bp_messages_add_meta()"
-----------------------------------+------------------------------
 Reporter:  johnjamesjacoby        |       Owner:  johnjamesjacoby
     Type:  defect (bug)           |      Status:  accepted
 Priority:  high                   |   Milestone:  2.2.2
Component:  Component - Messaging  |     Version:  2.2
 Severity:  minor                  |  Resolution:
 Keywords:  has-patch              |
-----------------------------------+------------------------------
Changes (by johnjamesjacoby):

 * owner:   => johnjamesjacoby
 * status:  new => accepted


Comment:

 Replying to [comment:4 DJPaul]:
 > We need to put `bp_message_add_meta` in the 2.2 deprecation file if we
 want this in 2.2.2 (which I think we should do).

 Agree. I'll take care of it.

 > Gosh darn it. I suck. Like JJJ, I find it highly unlikely that someone
 is using add_meta() instead of update_meta(), but I understand the
 concerns of those already using it.

 No you don't. These types of mistakes are easy to make (especially for us
 where there are already lots of these kinds of inconsistencies) and one of
 us should have caught it before 2.2 went out, myself specifically since I
 packaged it up.

 I'll take care of updating the patch and getting this in for 2.2.2. Thanks
 everyone for chiming in so quickly.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6270#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list