[buddypress-trac] [BuddyPress Trac] #6271: Separate activity WHERE conditions into new method

buddypress-trac noreply at wordpress.org
Sun Mar 1 19:52:20 UTC 2015


#6271: Separate activity WHERE conditions into new method
-----------------------------------+------------------
 Reporter:  johnjamesjacoby        |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  low                    |   Milestone:  2.3
Component:  Component - Activity   |     Version:  1.6
 Severity:  minor                  |  Resolution:
 Keywords:  2nd-opinion has-patch  |
-----------------------------------+------------------
Changes (by johnjamesjacoby):

 * keywords:  2nd-opinion => 2nd-opinion has-patch


Comment:

 [https://buddypress.trac.wordpress.org/attachment/ticket/6271/6271.01.patch
 6271.01.patch] separates out `$where_conditions` into a new
 `get_where_sql()` method. Tests still pass, and I haven't identified any
 breakage.

 The new method is marked protected, but not really for any other reason
 than it does no good to call it from outside the class anyways.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6271#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list