[buddypress-trac] [BuddyPress Trac] #6524: Add filter point before group membership requests are saved

[buddypress-trac]

#6524: Add filter point before group membership requests are saved
------------------------------------+------------------------------
 Reporter:  dcavins                 |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  low                     |   Milestone:  Awaiting Review
Component:  Component - Groups      |     Version:  1.0
 Severity:  minor                   |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------------------

Comment (by dcavins):

 Thanks for your comments, r-a-y!

 I think that your pre-save bail condition makes perfect sense in
 `BP_Groups_Member::save()`, since it would be applicable to every group
 membership case.

 I do wonder, though, about how easy it'd be for a beginner BP-er to find
 it and see how it could be used to stop a request from being created (like
 knowing how to identify membership requests vs invitations at the
 `groups_member_before_save` filter and that emptying the `user_id` would
 then torpedo the save).

 Maybe there's value to adding both approaches--the covers-every-case bail
 condition and the really-obviously-named filter. :)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6524#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac