[buddypress-trac] [BuddyPress Trac] #6525: Members and Groups avatars: Allow to set 'title' argument

[buddypress-trac]

#6525: Members and Groups avatars: Allow to set 'title' argument
---------------------------------+-----------------------------
 Reporter:  lenasterg            |       Owner:
     Type:  enhancement          |      Status:  new
 Priority:  low                  |   Milestone:  Future Release
Component:  Component - Any/All  |     Version:
 Severity:  minor                |  Resolution:
 Keywords:  needs-patch          |
---------------------------------+-----------------------------
Changes (by boonebgorges):

 * keywords:   => needs-patch
 * milestone:  Awaiting Review => Future Release


Comment:

 Thanks for the patch, lenasterg. I committed a few of the docblock
 improvements; [attachment:6525.3.patch] is your patch, minus these fixes.

 I agree with hnla that we generally should not be encouraging or enforcing
 the use of `title` on avatars. With that in mind, I'd like to suggest the
 following improvements to your patch:

 * Let's go ahead and add support for passing the `title` (and `alt`, where
 appropriate) attribute to functions like `bp_messages_thread_avatar()`. As
 you note, `bp_core_fetch_avatar()` supports the use of these attributes,
 so there's no reason why you shouldn't be able to use them in the
 wrappers. If possible, please consider writing unit tests for these new
 parameters - see [9960] for some examples.
 * In cases where the function is not already defining a `title`, let's
 leave the default value as an empty string `''` (eg
 `bp_message_thread_avatar()`). In cases where the function *is* already
 defining a title, make the default value the same as whatever the `title`
 currently is (eg `bp_get_group_avatar()`).
 * Let's not pass `title` attributes to `bp_core_fetch_avatar()` where they
 don't already exist. This means rolling back changes like those in
 `BP_Groups_Invite_Template::the_invite()`.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6525#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac