[buddypress-trac] [BuddyPress Trac] #6026: And if the Blogs component had Single items?
buddypress-trac
noreply at wordpress.org
Thu Jun 18 14:57:43 UTC 2015
#6026: And if the Blogs component had Single items?
------------------------------------------+------------------
Reporter: imath | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: Component - Blogs | Version:
Severity: normal | Resolution:
Keywords: dev-feedback has-patch early |
------------------------------------------+------------------
Comment (by johnjamesjacoby):
Replying to [comment:29 DJPaul]:
> This patch really needs to be split up into separate tickets/feature
enhancements. Happy to walk through it with you and find where we can do
this if you want.
>
> 200KB is alot of code. The more code you have, the worse any code review
will be. :)
I'm pretty strongly opposed to forcing Imath to break this patch up. It
doesn't matter if it's 1 patch or 25 small ones; the code changes are the
same, and the review process is the same:
* Apply patch
* See changed files
* Open a changed file
* Review changes
* Iterate if necessary
* Do the same for all other files
* Create an updated patch
* Repeat
I would like to avoid having several of us stomping on each other's
changes. In the case of massive feature development with Subversion, it
makes the most sense to have:
* One person does the architecting
* Submit their patch
* Pencil down and stop iterating
* Second person reviews the patch
* Iterates on the patch
* Submits a new patch
* Both individuals peer review each other until both agree it's ready for
core commit
* Once it's committed, we can all patch and iterate until 2.4.0 is
released
Sound like a plan?
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6026#comment:30>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list