[buddypress-trac] [BuddyPress Trac] #6506: Should not try to redirect in bp_has_message_threads

[buddypress-trac]

#6506: Should not try to redirect in bp_has_message_threads
-----------------------------------+------------------
 Reporter:  johnjamesjacoby        |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  2.4
Component:  Component - Messaging  |     Version:  1.0
 Severity:  normal                 |  Resolution:
 Keywords:                         |
-----------------------------------+------------------

Comment (by johnjamesjacoby):

 [https://buddypress.trac.wordpress.org/attachment/ticket/6506/6506.01.patch
 6506.01.patch] does two things:

 * Replace an early `return false;` with a `bp_do_404()` to prevent an
 empty page where there should be a 404
 * Remove the `bp_core_redirect( bp_displayed_user_domain() )` bit from
 `bp_has_message_threads()` since it's neither the correct location for
 this decision to be made, nor the right time to try and perform a
 redirection

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6506#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac