[buddypress-trac] [BuddyPress Trac] #6489: Messages star action links do not work for displayed users

[buddypress-trac]

#6489: Messages star action links do not work for displayed users
-----------------------------------+--------------------
 Reporter:  johnjamesjacoby        |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  2.3.2
Component:  Component - Messaging  |     Version:  2.3.0
 Severity:  normal                 |  Resolution:
 Keywords:  commit                 |
-----------------------------------+--------------------

Comment (by johnjamesjacoby):

 In [changeset:"9924"]:
 {{{
 #!CommitTicketReference repository="" revision="9924"
 Messages: Updates to `bp_get_the_message_star_action_link()`:

 * Set default `$user_id` so links work on displayed users
 * Use `switch` vs. `if/else` to make `$user_domain` calculation more
 obvious
 * Bail if `$user_domain` cannot be calculated
 * Cast a few variables to avoid non-integer issues cascading into other
 methods
 * Strict boolean comparisons to ensure proper execution
 * Escape output of a few HTML attributes

 This change allows for the action-link used to star a message to use the
 correct URL for the `user_id` that's passed into it. This is particularly
 helpful for capable community moderators that can view other user's
 Messages, so the links point to the correct URLs for the correct user.

 See #6489. (trunk)
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6489#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac