[buddypress-trac] [BuddyPress Trac] #6484: If post/activity comment sync is on, activity comment is never deleted when corresponding post comment is.

[buddypress-trac]

#6484: If post/activity comment sync is on, activity comment is never deleted when
corresponding post comment is.
-------------------------------+-----------------------
 Reporter:  imath              |      Owner:
     Type:  defect (bug)       |     Status:  new
 Priority:  high               |  Milestone:  2.4
Component:  Component - Blogs  |    Version:  2.0
 Severity:  major              |   Keywords:  has-patch
-------------------------------+-----------------------
 I had almost finished building a first patch for #6482 when i discovered
 something very problematic with the "post comment sync activity comment
 feature".

 having `! bp_disable_blogforum_comments()` (in other words comment sync is
 on), let's say i create a post, i comment it, then i add a reply to this
 comment.
 If i trash the parent comment, i still have the activity reply and the
 activity comment is now a spam. Which is the way it's built..

 Now, let's say i finally choose to delete permanently the parent comment
 from the Administration > Comments > Trash view. The post comment is
 deleted, but the activity comment is still a spam and the activity reply
 is not deleted (neither the corresponding comment).

 In this scenario, i saw other annoying side effects.. But it looks like if
 you trash a post comment, then delete it permanently, the corresponding
 activity comment is never deleted but remains a spam.

 I'm not sure but i think it's there since the introduction of the feature.

 The attached patch is fixing the issue. But i think there might be a need
 for a repair tool to remove spammed activity comments having no
 corresponding post comment.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6484>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac