[buddypress-trac] [BuddyPress Trac] #6509: Add BuddyPress Menus to Customizer

[buddypress-trac]

#6509: Add BuddyPress Menus to Customizer
-------------------------------------+------------------
 Reporter:  mercime                  |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  2.4
Component:  API                      |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |
-------------------------------------+------------------
Changes (by valendesigns):

 * keywords:  has-patch => has-patch needs-refresh


Comment:

 {{{
 if ( 0 !== $page || 'bp_nav' !== $obj_type ) {
     return $items;
 }
 }}}

 Is this condition really necessary? You have the code below it checking
 for `$obj_name` and retuning `$items` when it's not a BP menu object. It
 just seems redundant to me.

 Also, when setting up the `$items` array the classes key should have a
 string value. Otherwise, the output string for classes will have commas in
 it because the Customizer does not convert the array properly.

 So this line:
 {{{
 'classes' => array( 'bp-menu', "bp-{$bp_item->post_excerpt}-nav" )
 }}}
 Becomes
 {{{
 'classes' => "bp-menu bp-{$bp_item->post_excerpt}-nav"
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6509#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac