[buddypress-trac] [BuddyPress Trac] #5192: User roles with differents profile fields
buddypress-trac
noreply at wordpress.org
Tue Jul 14 14:59:10 UTC 2015
#5192: User roles with differents profile fields
----------------------------------+------------------
Reporter: _DorsVenabili | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: Component - XProfile | Version:
Severity: normal | Resolution:
Keywords: has-patch |
----------------------------------+------------------
Comment (by boonebgorges):
Replying to [comment:46 Offereins]:
> Just wondering whether we should account for member types that have been
unregistered. Picture a scenario were a member type was selected, but now
it only spooks around in the meta table without a tie to the real world.
It is only relevant when we're fetching labels, but we may need do an
`exists()` check. Or not?
Oh yeah, good call. I think we shouldn't bother with the meta table
itself. Plugins should be responsible for cleaning up their own messes,
and in any case we wouldn't want to delete content, since admins may
toggle a plugin on and off for testing, etc. However, we should definitely
have a check before outputting the label. And in fact, the code as it
stands will throw an error in this case. See lines 621-622 of
`get_member_type_label()` in
https://buddypress.trac.wordpress.org/attachment/ticket/5192/5192.3.diff.
This should get a sanity check for the next patch.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5192#comment:47>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list