[buddypress-trac] [BuddyPress Trac] #5192: User roles with differents profile fields

buddypress-trac noreply at wordpress.org
Tue Jul 14 11:40:27 UTC 2015


#5192: User roles with differents profile fields
----------------------------------+------------------
 Reporter:  _DorsVenabili         |       Owner:
     Type:  enhancement           |      Status:  new
 Priority:  normal                |   Milestone:  2.4
Component:  Component - XProfile  |     Version:
 Severity:  normal                |  Resolution:
 Keywords:  has-patch             |
----------------------------------+------------------

Comment (by Offereins):

 I really like where this is going! Huge thanks for your work, Boone :)

 In reply to [https://buddypress.trac.wordpress.org/ticket/5192#comment:40
 @boonebgorges]:
 * Some tests seem to use `$fg` in the assertions where I'd expect
 `$the_group` to be used (in `class-bp-xprofile-group`).

 In reply to [https://buddypress.trac.wordpress.org/ticket/5192#comment:43
 @imath]:
  3. I've read the discussion on Slack and the idea of the message
 accompanying the all-non-checked state gets a +1 from me.
  4. That restriction was already in my plugin and is adopted in the diff
 (bail on `1 === $field->id`). No harm there.
  5. +1, only labels for fields that are need an explanation.
  6. I agree with imath.
  7. Good catch! +1 as well, for both points. This thing we build can
 become complex, but we shouldn't forget there may be installations without
 any member type at all.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5192#comment:44>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list