[buddypress-trac] [BuddyPress Trac] #6487: Mentions.js fails on wp-admin post editor
buddypress-trac
noreply at wordpress.org
Tue Jul 14 08:25:47 UTC 2015
#6487: Mentions.js fails on wp-admin post editor
----------------------------------+--------------------
Reporter: dcavins | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.3.3
Component: Component - Activity | Version: 2.3.1
Severity: normal | Resolution:
Keywords: has-patch |
----------------------------------+--------------------
Comment (by DJPaul):
I was just thinking we fix the original problem and worry about support
for switching between tabs at some point in the future, but if you want to
fix it properly now, that's very responsible of you.
Your patch is actually the entire file :D but I get the idea from your
example. If that way is the only way to do it, I can live with putting it
into global scope, but let's namespace it like so:
{{{
window.bp = window.wp || {};
window.bp.mentions = window.bp.mentions || {};
}}}
or `bp.activity.mentions`, we haven't had a discussion on exactly how we
want to store this sort of thing in our JS.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6487#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list