[buddypress-trac] [BuddyPress Trac] #6552: XProfile: don't bail BP_XProfile_Group::save() when wpdb returns 0 rows affected

[buddypress-trac]

#6552: XProfile: don't bail BP_XProfile_Group::save() when wpdb returns 0 rows
affected
----------------------------------+---------------------------
 Reporter:  Offereins             |       Owner:  boonebgorges
     Type:  defect (bug)          |      Status:  closed
 Priority:  normal                |   Milestone:  2.4
Component:  Component - XProfile  |     Version:  2.3.0
 Severity:  normal                |  Resolution:  fixed
 Keywords:  has-patch             |
----------------------------------+---------------------------
Changes (by boonebgorges):

 * owner:   => boonebgorges
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"10002"]:
 {{{
 #!CommitTicketReference repository="" revision="10002"
 `BP_XProfile_Group::save()` should not return false when a save is
 successful but no rows are updated.

 It ought to be semantically possible to save a fieldgroup without making
 any
 changes to the group. Otherwise the return values of the `save()` method
 are
 inconsistent, and the 'xprofile_group_after_save' hook is not fired
 reliably.

 Props Offereins.
 Fixes #6552.
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6552#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac