[buddypress-trac] [BuddyPress Trac] #6164: remove redundant updating of metadata in groups_create_group()

buddypress-trac noreply at wordpress.org
Mon Jan 26 19:26:00 UTC 2015


#6164: remove redundant updating of metadata in groups_create_group()
--------------------------+-----------------------------
 Reporter:  jreeve        |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Core          |    Version:
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 While working on #6158, I noticed that `groups_create_group()` in `bp-
 groups/bp-groups-functions.php` was calling `groups_update_groupmeta()`:

 `groups_update_groupmeta( $group->id, 'last_activity',
 bp_core_current_time() );`

 but this was already being handled the right way by hooking
 `groups_update_last_activity()` into the action `groups_created_group` in
 `bp-groups/bp-groups-activity.php`:

 `add_action( 'groups_created_group',        'groups_update_last_activity'
 );`.

 Unless I'm mistaken (it's possible there's something about this I'm
 missing), this is redundant. The attached patch simply removes this
 redundant function call.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6164>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list