[buddypress-trac] [BuddyPress Trac] #6159: bp_activity_thumbnail_content_images() assumes img height/width is always set

buddypress-trac noreply at wordpress.org
Thu Jan 22 23:43:58 UTC 2015


#6159: bp_activity_thumbnail_content_images() assumes img height/width is always
set
--------------------------+-----------------------
 Reporter:  DJPaul        |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  2.3
Component:  Activity      |    Version:
 Severity:  normal        |   Keywords:  has-patch
--------------------------+-----------------------
 bp_activity_thumbnail_content_images parses `<img>` tags in the main
 content of an activity object, when generating a summary for the activity
 stream.

 The current implementation assumes that the img tag will always contain
 `width=` and `height=` properties. If the content doesn't contain these
 properties inside img tags, it causes PHP Warnings.

 I discovered this while working on another feature patch, so I don't have
 an easy unit test ready to prove the bug, though I've attached a patch.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6159>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list