[buddypress-trac] [BuddyPress Trac] #6125: Small improvements to Member Types functions
buddypress-trac
noreply at wordpress.org
Thu Jan 15 20:03:10 UTC 2015
#6125: Small improvements to Member Types functions
--------------------------+------------------
Reporter: Offereins | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.2
Component: Members | Version:
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+------------------
Comment (by johnjamesjacoby):
The `$output` parameter is only used in `user_admin_load()`, but not for
the names specifically anyways. We could eliminate it completely to
simplify the function and remove the hardcoded `names` bit entirely IMO.
Looking at this more makes me think the `bp_get_member_types()` function
is doing too much compared to other similar utility functions.
[https://buddypress.trac.wordpress.org/attachment/ticket/6125/6125.02.patch
6125.02.patch] simplifies `bp_get_member_types()` and introduces another
helper to filter those results if it ever becomes necessary.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6125#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list