[buddypress-trac] [BuddyPress Trac] #6116: Message ajax search not working

buddypress-trac noreply at wordpress.org
Tue Jan 13 17:38:39 UTC 2015


#6116: Message ajax search not working
-----------------------------------+------------------
 Reporter:  johnjamesjacoby        |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  2.2
Component:  Messaging              |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+------------------

Comment (by johnjamesjacoby):

 Replying to [comment:4 r-a-y]:
 > r9240 broke this to address #6010.
 >
 > For the patch, I would suggest `jq('#messages_search').val()` instead of
 `target.parent().children('input[type="text"]').val()`.

 This makes more sense to me. I don't love the idea of making a bunch of
 assumptions about random ID's in the DOM, but it does work, is the
 fastest, and mirrors our existing JS approaches elsewhere.

 Tangentially, anyone want to create a ticket to come up with a DOM element
 ID paradigm we should be adhering to and cleaning up existing code
 against?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6116#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list