[buddypress-trac] [BuddyPress Trac] #6112: Template notices html

[buddypress-trac]

#6112: Template notices html
--------------------------+-----------------------------
 Reporter:  slaFFik       |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Settings      |    Version:
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 We are an ordinary user, on Settings page.

 To change the password we input incorrect current one, new and repeat it.
 As the password is incorrect we get such an error:
 http://screencast.com/t/lZQtmvECC3t

 Please look at the no space between sentences. If you look at the html
 source code - everything will be in 1 `<p>` tag.
 If you look at the php source code around `No changes were made to your
 account` message, you will see that error messages are imploded using
 `</p><p>`. If you look at `bp_core_render_message()` you will see that
 there is no `<p>` tag around `echo $content`.

 So we have html that is generated by BP:

 {{{
 <div id="message" class="bp-template-notice error">
     Your current password is invalid.</p><p>No changes were made to your
 account.
 </div>
 }}}

 And the browser transforms it into:
 {{{
 <div id="message" class="bp-template-notice error">
     <p>Your current password is invalid.No changes were made to your
 account.</p>
 </div>
 }}}

 So the styling is wrong.

 Replicated on both BuddyPress 2.1.1 and 2.2 beta 1

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6112>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac