[buddypress-trac] [BuddyPress Trac] #6099: groups/favorites/friends activity scopes when displayed user has not any 'scope' items

[buddypress-trac]

#6099: groups/favorites/friends activity scopes when displayed user has not any
'scope' items
------------------------------+------------------
 Reporter:  imath             |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  high              |   Milestone:  2.2
Component:  Activity          |     Version:
 Severity:  major             |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+------------------
Changes (by boonebgorges):

 * keywords:  has-patch 2nd-opinion => has-patch commit


Comment:

 These fixes look correct to me. There was some discussion
 https://wordpress.slack.com/archives/buddypress/p1420808854002450 about
 whether `array( 0 )` is hackish, but IMO it is not - I think it's the
 right way to solve this. (The alternative would be to introduce a `0=1`
 type no-results clause, but the way that we build our SQL makes this
 difficult to do in a consistent way across components. The `array( 0 )`
 fix is much more straightforward, and I'd argue more semantically correct
 when it comes time to debug.)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6099#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac