[buddypress-trac] [BuddyPress Trac] #6090: Fix groups_join_group() & groups_accept_invite() behavior

[buddypress-trac]

#6090: Fix groups_join_group() & groups_accept_invite() behavior
------------------------------+------------------
 Reporter:  dcavins           |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  2.2
Component:  Groups            |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+------------------

Comment (by r-a-y):

 > I'm a bit worried about the use of BP_Groups_Member::delete in
 groups_delete_membership_request() because that will delete any record
 that involves the user and group, which could include any requests,
 invitations or memberships, right?

 After thinking about this some more, I think you are right.  Internally,
 `groups_delete_membership_request()` is always called with
 `groups_check_for_membership_request()` right before it.  So I would be
 okay with the change with the caveat (and in the spirit of boonebgorges)
 that we add in a unit test exhibiting the conflict when using
 `groups_delete_membership_request()` against requests and invites.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6090#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac