[buddypress-trac] [BuddyPress Trac] #6090: Fix groups_join_group() & groups_accept_invite() behavior

[buddypress-trac]

#6090: Fix groups_join_group() & groups_accept_invite() behavior
------------------------------+------------------
 Reporter:  dcavins           |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  2.2
Component:  Groups            |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+------------------
Changes (by r-a-y):

 * keywords:  has-patch => has-patch commit
 * milestone:  Awaiting Review => 2.2


Comment:

 For `01.patch`:

 > The problem is that the function groups_delete_membership_request() was
 being used with the parameters in the wrong order. It expects, in this
 order:
 > $membership_id, $user_id, $group_id
 >But in groups_join_group() and groups_accept_invite() we were using it
 with these >parameters:
 >groups_delete_membership_request( $user_id, $group_id )

 Yikes!  Good catch!  Go ahead and commit these changes.

 >  I've also changed groups_delete_membership_request() to use
 BP_Groups_Member::delete_request() which is bit more restrained than
 BP_Groups_Member::delete.

 However, I would hold off on making the `delete_request()` method change
 in `groups_delete_membership_request()`.  Some devs might be using this
 function in this open manner.

 Also go ahead with `02.patch`.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6090#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac