[buddypress-trac] [BuddyPress Trac] #6229: Notification content

[buddypress-trac]

#6229: Notification content
---------------------------------------+--------------------
 Reporter:  danbp                      |       Owner:
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  2.2.2
Component:  Component - Notifications  |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  2nd-opinion                |
---------------------------------------+--------------------
Changes (by johnjamesjacoby):

 * keywords:  needs-patch => 2nd-opinion


Comment:

 [https://buddypress.trac.wordpress.org/attachment/ticket/6229/6229.01.patch
 6229.01.patch] includes a fix and unit test to support results of
 `BP_Notifications_Notification::get()` return the correctly paginated
 results.

 It also adds a `query_vars` variable to `BP_Notifications_Template` which
 is a bit redundant, but it proved helpful for passing the same array to
 both `BP_Notifications_Notification::get()` and
 `BP_Notifications_Notification::get_total_count()` and for keeping
 pristine the variables used to translate the request into queried results.
 Since no other components work this way, I'm open to removing it and using
 a locally scoped array instead, but I thought it was a neat so included it
 here.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6229#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac