[buddypress-trac] [BuddyPress Trac] #6189: Query string in directory URL breaks AJAX pagination
buddypress-trac
noreply at wordpress.org
Mon Feb 23 21:22:00 UTC 2015
#6189: Query string in directory URL breaks AJAX pagination
-----------------------------------+------------------
Reporter: dontdream | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.3
Component: Component - Members | Version:
Severity: normal | Resolution:
Keywords: has-patch 2nd-opinion |
-----------------------------------+------------------
Comment (by dontdream):
I've tested your patch and it works fine. Thanks!
Long explanation: WP 4.1.1 introduced a change that is relevant to this
ticket. As you can see comparing my original post with my comment:3, WP
4.1.1 is the first version that insists on putting all the original query
args into the pagination links, even if we set $base to an empty string.
Before 4.1.1, the whole query string was dropped setting $base to an empty
string when (DOING_AJAX == false), so I was suggesting to drop the whole
query string even when (DOING_AJAX == true).
After 4.1.1, the query string is no longer dropped when (DOING_AJAX ==
false), so it's reasonable to do the same when (DOING_AJAX == true).
6189.diff does just that, leaves the 'upage' query var in the first
position, and keeps the existing JavaScript happy :)
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6189#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list