[buddypress-trac] [BuddyPress Trac] #6244: Custom Component Directory pages mappings removed when BuddyPress Componets selection saved in admin

[buddypress-trac]

#6244: Custom Component Directory pages mappings removed when BuddyPress Componets
selection saved in admin
--------------------------------------+--------------------
 Reporter:  sbrajesh                  |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  2.2.2
Component:  General - Administration  |     Version:  2.2
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch                 |
--------------------------------------+--------------------
Changes (by imath):

 * keywords:  needs-patch needs-unit-tests => has-patch


Comment:

 I've chosen to edit the
 `bp_core_admin_get_active_components_from_submitted_settings()` as the
 `bp_is_active()` check in the `bp_core_get_directory_page_ids()` was an
 improvement introduced in 2.2 and i think
 `bp_core_admin_get_active_components_from_submitted_settings()` should
 only take care of the BuddyPress built in components.

 So 6244.patch is setting an array of custom components by difference
 between the packaged components and the active components. Then i let the
 switch part do his job : setting the packaged active components. Finally i
 return the pakaged components + the custom ones by merging the two arrays.

 6244.unittest.patch is only containing the unit test.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6244#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac