[buddypress-trac] [BuddyPress Trac] #5972: Password strength meter's JS re-uses theme compat. asset handle

[buddypress-trac]

#5972: Password strength meter's JS re-uses theme compat. asset handle
-----------------------------------------+-----------------------
 Reporter:  DJPaul                       |       Owner:  DJPaul
     Type:  defect (bug)                 |      Status:  assigned
 Priority:  normal                       |   Milestone:  2.3
Component:  Appearance - Template Parts  |     Version:  2.1
 Severity:  major                        |  Resolution:
 Keywords:  has-patch                    |
-----------------------------------------+-----------------------

Comment (by boonebgorges):

 I'm definitely fine with adding another param to make the asset handle
 customizable.

 I'm wondering whether `$script_name` should completely override the
 existing logic, or whether we should maintain the `$location_type` prefix.
 Even in the case of custom scripts, it seems as if it would be useful to
 maintain information about where in the stack the asset is found. Thus:

 {{{
 $retval['handle']   = ( $script_name ) ? "{$location_type}-{$script_name}
 : "{$location_type}-{$type}";
 }}}

 I suppose an argument against this is that our "main" assets -
 buddypress.css and buddypress.js don't have a natural "name" - we just
 call them 'bp-legacy-css' etc.

 What do you think, DJPaul? Am I overthinking it?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5972#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac